feat: umd support mako bundler #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeachScript
reviewed
Jun 4, 2024
| path.dirname(require.resolve('@umijs/bundler-webpack/package.json')), | ||
| ); | ||
|
|
||
| const makoBundler = importLazy( | ||
| // path.dirname(require.resolve('/Users/xiaoxiao/work/mako/packages/bundler-mako/package.json')), |
PeachScript
reviewed
Jun 4, 2024
src/builder/bundle/index.ts
Outdated
| watch: opts.watch, | ||
| DevServer: false, |
PeachScript
reviewed
Jun 4, 2024
PeachScript
reviewed
Jun 4, 2024
PeachScript
reviewed
Jun 4, 2024
| }, | ||
| } | ||
| : {}), | ||
| onBuildComplete({ isFirstCompile, close }: any) { |
There was a problem hiding this comment.
onBuildComplete 在 dev 时是不执行的，后续结合 onDevCompileDone 优化日志输出，以及 bundler-webpack 是否能统一使用 onDevCompileDone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
配置变化
.fatherrc.ts新增umd: { bundler: 'webpack' | 'mako' }的配置项做切换环境变量
OKAM=@alipay/umi-bundler-okam 指定 mako bundler
examples/mako