Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about URL scope when editing Targets #646

Open
anjackson opened this issue Feb 5, 2020 · 3 comments
Open

Warn about URL scope when editing Targets #646

anjackson opened this issue Feb 5, 2020 · 3 comments
Assignees

Comments

@anjackson
Copy link
Contributor

anjackson commented Feb 5, 2020

In general, all URLs like http://example.com/subsection should raise a warning, as the lack of a trailing slash means the whole site is in scope: http://example.com/

Similarly, http://example.com/subsection/subsub scopes in http://example.com/subsection.

This is particularly important for large platform sites, and where open access is being inherited.

NOTE that this scoping issue applies to the URL path, and any query parameters should be dropped before determining the scope.

@min2ha
Copy link
Contributor

min2ha commented Feb 5, 2020

Isn't it the case where we'll be forced to double ask every time what curator meant?
I.e. on every new target pop up dialog with 2 options about the scope: 1. whole site (ending with /) or 2. subsection (ending without /) ? And the question Are you sure?

@anjackson
Copy link
Contributor Author

anjackson commented Feb 5, 2020

I was thinking it should accept the URL, but flash up a warning (like it does for crawl-date-in-the-past). With a message like this for each affected:

The URL http://example.com/section has no trailing slash, so the whole of https://example.com/ will be considered part of this Target. If that's not what you intended, you should edit this URL accordingly.

But maybe best to run it past @nicolabingham and see what she wants?

@nicolabingham
Copy link

@anjackson, yes, I'd like this situation to flag up a warning with the text as you suggest. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants