Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify dropout usage #800

Open
jindrahelcl opened this issue Mar 13, 2019 · 0 comments
Open

Unify dropout usage #800

jindrahelcl opened this issue Mar 13, 2019 · 0 comments

Comments

@jindrahelcl
Copy link
Member

There are two clashing ways to use dropout in model parts - on the output or the input.

@varisd suggested going with the first option (each model part is responsible for dropping out its outputs), but this requires a greater deal of work since the majority of the codebase is done the other way (except for transformer components).

I now prefer the first option. We could even introduce a new decorator which would apply dropout on a returned value from the decorated method, provided that the class has the dropout_keep_prob field.

@jindrahelcl jindrahelcl changed the title Unify dropout guidelines Unify dropout usage Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant