You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should increase pylint limits for too-many-arguments and too-many-locals (which is influenced by the arguments which count as well towards this number).
For example, the current maximum of arguments is 8. Since the ModelPart parent class has five of them, this leaves almost no space for classes that are derived from this class.
The maximum number of arguments used in neuralmonkey is in the RNN decoder constructor (23) and there is a bunch of other functions with arg number > 20. The mean argument number (of those larger than 8) is around 12-15.
I propose to raise this number globally to e.g. 15 or 20, because now the pylint warning about too many arguments is just not useful and everyone is ignoring it and the code is full with pylint: disable lines..
The text was updated successfully, but these errors were encountered:
Nemyslím si, že Python ví, co je to konstruktor :-P
Podle mne by se věci, které mají dvacet argumentů, měly refaktorovat (zkusit smysluplně rozdělit na menší části, které se nakonfigurují zvlášť a pak se spojí). Ale na druhou stranu uznávám, že v Pythonu je to asi idiomatické -- když čtu dokumentaci k matplotlibu, jsou tam všude konstruktory s desítkami arguementů.
We should increase pylint limits for
too-many-arguments
andtoo-many-locals
(which is influenced by the arguments which count as well towards this number).For example, the current maximum of arguments is 8. Since the
ModelPart
parent class has five of them, this leaves almost no space for classes that are derived from this class.The maximum number of arguments used in neuralmonkey is in the RNN decoder constructor (23) and there is a bunch of other functions with arg number > 20. The mean argument number (of those larger than 8) is around 12-15.
I propose to raise this number globally to e.g. 15 or 20, because now the pylint warning about too many arguments is just not useful and everyone is ignoring it and the code is full with
pylint: disable
lines..The text was updated successfully, but these errors were encountered: