Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify restoring variables #350

Open
jindrahelcl opened this issue Mar 8, 2017 · 1 comment
Open

Unify restoring variables #350

jindrahelcl opened this issue Mar 8, 2017 · 1 comment
Labels

Comments

@jindrahelcl
Copy link
Member

As I looked through the code, in tf_manager.__init__(), there is an option to supply initial variable files. There is a similar option in [main] section of the config. I did not investigate if the two are colliding in any way, but I find it strange at least.

So, my preferred solution is to throw the initial_variables out of learning_utils and leave only those in tf_manager.

With the refactoring for TF 1.0, I will move all remaining saving and restoring functionality from learning_utils to tf_manager anyway. (Including the decision whether to save the variables according to their score.)

@jlibovicky
Copy link
Contributor

Sounds reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants