fix(bubble-menu): add focusout handler for floating element #5882
+17
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 32c4b2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bdbch
requested changes
Nov 30, 2024
| @@ -50,7 +50,7 @@ export const BubbleMenu = (props: BubbleMenuProps) => { | |||
| }, [props.editor, currentEditor, element]) | |||
|
|
|||
| return ( | |||
| <div ref={setElement} className={props.className} style={{ visibility: 'hidden' }}> | |||
| <div ref={setElement} tabIndex={-1} className={props.className} style={{ visibility: 'hidden' }}> | |||
There was a problem hiding this comment.
Did you test if a negative tab index still allows the client to focus elements inside the div via the keyboard?
There was a problem hiding this comment.
Yes, you can still focus on other elements inside using tab
This is necessary so that event.relatedTarget is not null if an empty space was clicked inside the bubble-menu
Co-authored-by: bdbch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Fix the bug where the bubble menu does not hide
Implementation Approach
Add an additional focusout event handler to the floating element.
Also, set tabIndex to -1 for the bubble menu to ensure that clicking on an empty block in the bubble menu does not result in the parentNode being null.
Testing Done
Test on a local
Verification Steps
Add input into bubble-menu demo
Open BubbleMenu
Click on the input
Click outside the editor
Additional Notes
Checklist
Related Issues
#578