JessicaH- Add day number on CommonsOverview #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In this PR, I added tests for calcualteDays and moved this function into dateUtils. An extra parameter, currentDate, is passed in to the function so that it can be tested with mock current dates. |
ykeung
reviewed
Jun 3, 2023
pconrad
added
the
FIXME-Needs peer CR
jessicahsy
removed
the
FIXME-Needs peer CR
pconrad
approved these changes
Jun 4, 2023
pconrad
added
Merge Candidate
pconrad
requested changes
Jun 4, 2023
pconrad
added
the
FIXME-Test failures
pc - demo mocking date for CommonsOverview test
jessicahsy
changed the title
jessicahsy
removed
the
FIXME-Test failures
kshitij0407
approved these changes
Jun 6, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the code from my last PR for font change that has not been merged yet. Review only CommonsOverview.js and dayUtils.js
In this PR, I added a utility to calculate the number of days since the starting day. Previously, the commons.day is empty. The new function is called and assigned to this variable so that it displays the right day number in CommonsOverview. May be adding test cases and error messages for starting dates set the future, or maybe change so that admin cannot create a starting date beyond the current date.
Storybook
Screenshots
Before:
After:
