Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Improve internal Backend message #28

Open
Anthonypella opened this issue Jun 1, 2023 · 0 comments
Open

REFACTOR: Improve internal Backend message #28

Anthonypella opened this issue Jun 1, 2023 · 0 comments
Assignees

Comments

@Anthonypella
Copy link
Contributor

Anthonypella commented Jun 1, 2023

Have you updated the title?
I have updated the issue's title.
Discussion
The API endpoints that toggle the driver, rider, and admin status for a user typically return messages like this one:

{
"message": "User with id 2 has toggled driver status"
}
It would be far more useful for devlopers to see something like this:

{
"message": "User with id 2 has toggled driver status from false to true"
}
OR:

{
"message": "User with id 2 has toggled driver status from true to false"
}
Acceptance Criteria:

The message for toggling admin has been updated to the new format.
The message for toggling driver has been updated to the new format.
The message for toggling rider has been updated to the new format.
Implementation Todos:

Frontend:

None.
Backend:

Fix message in UsersController for toggleAdmin and update tests.
Fix message in UsersController for toggleDriver and update tests.
Fix message in UsersController for toggleRider and update tests.

@Anthonypella Anthonypella self-assigned this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant