Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case failing because of SpaCy 1.9 #368

Closed
pminervini opened this issue Mar 18, 2018 · 5 comments
Closed

Test case failing because of SpaCy 1.9 #368

pminervini opened this issue Mar 18, 2018 · 5 comments

Comments

@pminervini
Copy link
Collaborator

https://app.wercker.com/JohannesMaxWel/jack/runs

jack uses spacy==1.9, which in turn does import pip, which is an unsupported behavior:

pypa/pip#5081

The problem does not exist when using the latest spacy.

@pminervini
Copy link
Collaborator Author

I've just opened an issue on the SpaCy github: explosion/spaCy#2112

@pminervini
Copy link
Collaborator Author

If we need to stick to the 1.x branch of SpaCy, I'll commit a patch to their codebase after I'm done with the paper; otherwise we can simply switch to the latest version

@dirkweissenborn
Copy link
Collaborator

I would rather stick to 1.9 for now, because it is much faster on processing small documents which is more important at the moment. 2.0 was pretty bad, though I haven't checked recently. See #338

@pminervini
Copy link
Collaborator Author

Hey! I've temporarily switched to spacy (instead of spacy==1.x) to make jack work - now the tests turn out green.

There is a pull request to fix this on the 1.x branch of spacy - I'll switch back to 1.x when it's merged. Let's keep this issue open as a reminder!

@pminervini
Copy link
Collaborator Author

Fixed: explosion/spaCy#2112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants