Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PXD-1962 ⁃ add name-length check to dictionary validation script #22

Open
philloooo opened this issue Sep 28, 2018 · 2 comments
Open

PXD-1962 ⁃ add name-length check to dictionary validation script #22

philloooo opened this issue Sep 28, 2018 · 2 comments
Labels
bug

Comments

@philloooo
Copy link
Contributor

Dictionary validation does not detect node names that are too long for postgres - ex:


IdentifierError: Identifier 'node_impulsivecompulsivedisordersquestionnaire__sysan__props_idx' exceeds maximum length of 63 characters
@philloooo philloooo added the bug label Sep 28, 2018
@philloooo
Copy link
Contributor Author

we should just shorten the name, gdcdatamodel already do this for edge table

https://github.com/uc-cdis/gdcdatamodel/blob/develop/gdcdatamodel/models/__init__.py#L372

@philloooo
Copy link
Contributor Author

➤ Benjamin Rohrer commented:

[~[email protected]], in the code you linked, the author comments "This is rather an undesirable workaround". Are we sure want to replicate it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philloooo