Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

Should the user-set state of "desktop mode" be saved and restored on reboot? #343

Open
UniversalSuperBox opened this issue Nov 16, 2020 · 2 comments
Labels

Comments

@UniversalSuperBox
Copy link
Member

UniversalSuperBox commented Nov 16, 2020

If the user manually sets "Desktop Mode" on a large-screened device while it is not attached to a keyboard, should we save that setting and restore it on a reboot?

The checks would roughly go like:

Is this device large enough to show the desktop mode switch?
If so, did the user manually enable desktop mode at any point?
If so, enable desktop mode.

This logic would run counter to the automatic mode switch currently available in Lomiri. Effectively it would mean that once Desktop Mode was set with the device detached from a keyboard, it would never be unset upon a keyboard detach. No matter the automatic state of the shell, the manual "On" state of the Desktop Mode switch would override it.

On devices which are too small to show the desktop mode switch, the manual state of the switch would be ignored (sorry, UT Tweak Tool users, but we really don't want people getting stuck).

Does this sound acceptable?

@cibersheep
Copy link
Contributor

The checks would roughly go like:

Is this device large enough to show the desktop mode switch?
If so, did the user manually enable desktop mode at any point?
If so, enable desktop mode.

This sounds cool behaviour

On devices which are too small to show the desktop mode switch, the manual state of the switch would be ignored (sorry, UT Tweak Tool users, but we really don't want people getting stuck).

UTTT has 3 modes: desktop, stage and automatic. Are those coming from Lomiri I guess.
What device can get stuck in desktop mode? Launcher is always accessible and windows are easily snappable and resizable, etc. In what case desktop mode is a problem in a phone?
Also, I think the use of UTTT is clearly for advanced users.

@kugiigi
Copy link
Contributor

kugiigi commented Jan 4, 2021

This sounds good to me. I also have this issue since I use multi-device kb/mouse and everytime I switch out, UT switches back to staged mode.. However, I don't agree of fully disabling setting desktop mode on small screens. Actually, I'll go as far as removing the restriction for the desktop mode and have it always available in the indicator and maybe rename it to windowed mode. Maybe in the future we'll have tiling mode too 😛

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants