Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Defaults for Downstreams #129

Open
gerblesh opened this issue Aug 26, 2024 · 1 comment
Open

Better Defaults for Downstreams #129

gerblesh opened this issue Aug 26, 2024 · 1 comment

Comments

@gerblesh
Copy link
Collaborator

gerblesh commented Aug 26, 2024

The ublue-update defaults have shown to be not ideal for downstream. Issues with battery checks in psutil means that the battery percentage check is broken and often needs to be disabled (#79), and both Bluefin and Bazzite set similar defaults in the ublue-update.toml file:

Notably both disable dbus_notify meaning a large portion of the codebase is not being used downstream. For this I want to have an open discussion about creating better, more preferred defaults for downstreams and also discuss the potential removal or revamp of dbus notifications in ublue-update

@fiftydinar
Copy link

fiftydinar commented Aug 26, 2024

dbus_notify should be false by default imo.
It's still an useful function, so I think that it shouldn't be removed, but refactored.

I thought that psutil thing is fixed by using downstream patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants