Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipBotEvents set to false still seems to skip bot events #98

Closed
gentlementlegen opened this issue Aug 29, 2024 · 5 comments
Closed

skipBotEvents set to false still seems to skip bot events #98

gentlementlegen opened this issue Aug 29, 2024 · 5 comments
Assignees

Comments

@gentlementlegen
Copy link
Member

Even when set to false the events triggered by a bot do not seem to be dispatched by the kernel, for example after a automated-merging action that should trigger a conversation-rewards by closing the issue but doesn't happen, like here. The proper behavior would be to have to action / worker triggered when this is set to false in the configuration.

@Keyrxng
Copy link
Contributor

Keyrxng commented Aug 29, 2024

Related to #94 I'm sure

@gentlementlegen
Copy link
Member Author

It seems that this works as long as skipBotEvents is placed at the top of the plugins section. Test run here: Meniole/daemon-merging#7

@gentlementlegen gentlementlegen closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2024
Copy link
Contributor

ubiquity-os bot commented Sep 9, 2024

# Issue was not closed as completed. Skipping.

@0x4007
Copy link
Member

0x4007 commented Sep 9, 2024

I filed a new plugin that might rely on not automatically generating permits from these automated merges as a heads up. Perhaps we shouldn't "fix" this "feature" yet @gentlementlegen

@gentlementlegen
Copy link
Member Author

@0x4007 It's not broken so nothing to be fixed, I misunderstood how to use this configuration value if we want to run plugins on bot actions. You can configure it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants