Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text formatting issue on /stop if the user is not assigned #32

Closed
gentlementlegen opened this issue Aug 28, 2024 · 11 comments · Fixed by #33
Closed

Text formatting issue on /stop if the user is not assigned #32

gentlementlegen opened this issue Aug 28, 2024 · 11 comments · Fixed by #33

Comments

@gentlementlegen
Copy link
Member

There seem to be an issue with the displayed text in this scenario:
ubiquibot/sandbox#21 (comment)

The output should be

! You are not assigned to this task
@obeys
Copy link
Contributor

obeys commented Aug 30, 2024

/start

Copy link
Contributor

ubiquity-os bot commented Aug 30, 2024

! Please set your wallet address with the /wallet command first and try again.

Copy link
Contributor

ubiquity-os bot commented Aug 30, 2024

! No wallet address found

@obeys
Copy link
Contributor

obeys commented Aug 30, 2024

/wallet 0x31BcF24D34F018B3Aee4c6E97307221aFe47bc96

Copy link
Contributor

ubiquity-os bot commented Aug 30, 2024

+ Successfully registered wallet address

@obeys
Copy link
Contributor

obeys commented Aug 30, 2024

/start

Copy link
Contributor

ubiquity-os bot commented Aug 30, 2024

DeadlineSat, Aug 31, 12:31 AM UTC
Registered Wallet 0x31BcF24D34F018B3Aee4c6E97307221aFe47bc96
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@0x4007
Copy link
Member

0x4007 commented Aug 31, 2024

! No wallet address found

@gentlementlegen I think Star runs twice

@gentlementlegen
Copy link
Member Author

@0x4007 I think both errors got triggered in the same run which caused 2 messages to be posted. I checked the configuration and the plugin is only there once, so I believe it is more of a code logic issue.

@0x4007
Copy link
Member

0x4007 commented Aug 31, 2024

I think output from each plugin should be standardized with reward amount, message, and message level.

Message referring to a single string to comment.

Copy link
Contributor

ubiquity-os bot commented Sep 2, 2024

[ 12.5 WXDAI ]

@cohow
Contributions Overview
View Contribution Count Reward
Issue Task 1 12.5
Review Comment 5 0
Conversation Incentives
Comment Formatting Relevance Reward
Resolves #32 <!-- - You must link the issue number e.g. "Re…
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 2
        multiplier: 0
    score: 1
  ul:
    symbols:
      \b\w+\b:
        count: 45
        multiplier: 0
    score: 1
  li:
    symbols:
      \b\w+\b:
        count: 35
        multiplier: 0
    score: 1
multiplier: 0
- -
while rebasing it seems like i merged a new commit from developm…
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 25
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
should be good to go now I believe I'll make sure to remember t…
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 20
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
@gentlementlegen requested changes have been done, sorry about t…
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 15
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
Okay I think I finally got it right this time... I forgot to add…
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 48
        multiplier: 0.2
    score: 1
multiplier: 0
1 -

[ 1.8 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Comment 2 1.8
Conversation Incentives
Comment Formatting Relevance Reward
@gentlementlegen I think Star runs twice
0.6
content:
  p:
    symbols:
      \b\w+\b:
        count: 6
        multiplier: 0.1
    score: 1
multiplier: 1
0.2 0.12
I think output from each plugin should be standardized with rewa…
2.4
content:
  p:
    symbols:
      \b\w+\b:
        count: 24
        multiplier: 0.1
    score: 1
multiplier: 1
0.7 1.68

[ 31.4 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Specification 1 18.3
Issue Comment 1 4.8
Review Comment 4 8.3
Conversation Incentives
Comment Formatting Relevance Reward
There seem to be an issue with the displayed text in this scenar…
18.3
content:
  p:
    symbols:
      \b\w+\b:
        count: 26
        multiplier: 0.1
    score: 1
  pre:
    symbols:
      \b\w+\b:
        count: 7
        multiplier: 0.1
    score: 0
  code:
    symbols:
      \b\w+\b:
        count: 7
        multiplier: 0.1
    score: 5
multiplier: 3
1 18.3
@0x4007 I think both errors got triggered in the same run which …
8
content:
  p:
    symbols:
      \b\w+\b:
        count: 40
        multiplier: 0.2
    score: 1
multiplier: 1
0.6 4.8
Will approve when commit is renamed.
0.6
content:
  p:
    symbols:
      \b\w+\b:
        count: 6
        multiplier: 0.1
    score: 1
multiplier: 1
1 0.6
Why was this changed?
0.4
content:
  p:
    symbols:
      \b\w+\b:
        count: 4
        multiplier: 0.1
    score: 1
multiplier: 1
1 0.4
Seems to work fine when tested on my organization: https://githu…
4.8
content:
  p:
    symbols:
      \b\w+\b:
        count: 48
        multiplier: 0.1
    score: 1
multiplier: 1
1 4.8
Supposedly the webhooks should run with husky before you commit.…
2.5
content:
  p:
    symbols:
      \b\w+\b:
        count: 25
        multiplier: 0.1
    score: 1
multiplier: 1
1 2.5

[ 18.6 WXDAI ]

@Keyrxng
Contributions Overview
View Contribution Count Reward
Review Comment 3 18.6
Conversation Incentives
Comment Formatting Relevance Reward
Thanks for the PR @cohow This doesn't affect the working logic…
8.5
content:
  p:
    symbols:
      \b\w+\b:
        count: 84
        multiplier: 0.1
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 1
multiplier: 1
1 8.5
@cohow take a look at [this cheatsheet](https://gist.github.com/…
3.8
content:
  p:
    symbols:
      \b\w+\b:
        count: 34
        multiplier: 0.1
    score: 1
  a:
    symbols:
      \b\w+\b:
        count: 2
        multiplier: 0.1
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 2
        multiplier: 0.1
    score: 1
multiplier: 1
1 3.8
I actually tested your commit title locally in this repo without…
6.3
content:
  p:
    symbols:
      \b\w+\b:
        count: 61
        multiplier: 0.1
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 2
        multiplier: 0.1
    score: 1
multiplier: 1
1 6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants