Skip to content
This repository has been archived by the owner on Aug 29, 2024. It is now read-only.

update rpc-handler #39

Open
Keyrxng opened this issue Aug 26, 2024 · 25 comments · May be fixed by #40 or #41
Open

update rpc-handler #39

Keyrxng opened this issue Aug 26, 2024 · 25 comments · May be fixed by #40 or #41

Comments

@Keyrxng
Copy link
Member

Keyrxng commented Aug 26, 2024

This plugin is using my published package and not the official ubiquity package

  • "@keyrxng/rpc-handler": "^1.0.3" - remove
  • "@ubiquity-dao/rpc-handler": "^1.3.0" - replace
@zugdev
Copy link

zugdev commented Aug 27, 2024

/wallet 0xbB689fDAbBfc0ae9102863E011D3f897b079c80F

Copy link

ubiquity-os bot commented Aug 27, 2024

+ Successfully registered wallet address

@zugdev zugdev linked a pull request Aug 27, 2024 that will close this issue
@zugdev
Copy link

zugdev commented Aug 28, 2024

/start

1 similar comment
@Keyrxng
Copy link
Member Author

Keyrxng commented Aug 28, 2024

/start

Copy link

ubiquity-os bot commented Aug 28, 2024

DeadlineWed, Aug 28, 10:48 AM UTC
Registered Wallet 0xAe5D1F192013db889b1e2115A370aB133f359765
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@Keyrxng
Copy link
Member Author

Keyrxng commented Aug 28, 2024

/stop

Copy link

ubiquity-os bot commented Aug 28, 2024

# You have been unassigned from the task

@Keyrxng
Copy link
Member Author

Keyrxng commented Aug 28, 2024

@zugdev can you use the /start command again and assign this. I'm unsure why it did not assign you the first time

@gentlementlegen it's not trivial to access our worker logs is it? i.e need correct access etc

@gentlementlegen
Copy link
Member

@Keyrxng Sadly no, you need to live check the logs, we do not retain them. We can consider pushing them to a db but it will be huge. Cloudflare has a log system but it's a paying feature.

@Keyrxng
Copy link
Member Author

Keyrxng commented Aug 28, 2024

I see, we can only assume it was a rate limit of some kind considering my comment went through okay. If it happens again I'll make a point of implementing a core plugin logger with SB posting but this is the first time I've seen it

@Dhruv245
Copy link

/start

Copy link

ubiquity-os bot commented Aug 28, 2024

! Please set your wallet address with the /wallet command first and try again.

@Dhruv245
Copy link

/wallet 0x648a958766de4cba2C9884C3c703c40392923163

Copy link

ubiquity-os bot commented Aug 28, 2024

+ Successfully registered wallet address

@Dhruv245
Copy link

/start

1 similar comment
@Dhruv245
Copy link

/start

Copy link

ubiquity-os bot commented Aug 28, 2024

DeadlineWed, Aug 28, 11:29 AM UTC
Registered Wallet 0x648a958766de4cba2C9884C3c703c40392923163
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@0x4007
Copy link
Member

0x4007 commented Aug 28, 2024

@gentlementlegen it's not trivial to access our worker logs is it? i.e need correct access etc

We just have to manually invite their Cloudflare account with read only access I believe.

@gentlementlegen
Copy link
Member

@0x4007 Yes but we cannot retroactively check the logs, so in this case it would not be helpful.

@Dhruv245 Dhruv245 linked a pull request Aug 28, 2024 that will close this issue
@gentlementlegen
Copy link
Member

@zugdev Should have been assigned and this task un-assignable in the first place. There is an issue on that regard here. @Keyrxng that would be truly appreciated that you focus on ubiquity-os-marketplace/command-start-stop#19 so this case doesn't happen again.

@Keyrxng
Copy link
Member Author

Keyrxng commented Aug 28, 2024

@Dhruv245 @zugdev

I don't think either PR has correctly implemented the required changes so it's first one to completion gets the reward. I will assign the PR author to the task before merging.

Where the package is used in the codebase, does anything need updated such as init values etc? If you are confident that you have made the required changes and there are no errors introduced request a review from myself please


And @gentlementlegen I will do it later tonight as I have an apt to get to shortly

@zugdev
Copy link

zugdev commented Aug 28, 2024

/start

Copy link

ubiquity-os bot commented Aug 28, 2024

DeadlineWed, Aug 28, 2:40 PM UTC
Registered Wallet 0xbB689fDAbBfc0ae9102863E011D3f897b079c80F
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@0x4007
Copy link
Member

0x4007 commented Aug 28, 2024

It's strange that the start command is unreliable. Perhaps we can save logs to our database as we used to for review temporarily.

@0x4007
Copy link
Member

0x4007 commented Aug 29, 2024

I just realized that this is the first version of conversation rewards. We should archive this repository as it is deprecated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.