forked from actions/runner-images
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract common steps to the script files #1
Draft
enescakir
wants to merge
10
commits into
ubicloud
Choose a base branch
from
extract-script
base: ubicloud
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enescakir
force-pushed
the
ubicloud
branch
4 times, most recently
from
May 9, 2024 07:10
d9f7b90
to
80ca0d5
Compare
enescakir
force-pushed
the
ubicloud
branch
2 times, most recently
from
May 14, 2024 06:48
0990436
to
cab186f
Compare
The new version of az cli started to throw an exception for pending downloads. Azure/azure-cli#10160 (comment)
enescakir
force-pushed
the
ubicloud
branch
7 times, most recently
from
May 23, 2024 14:18
911430a
to
90f9a56
Compare
Huh, why is so much added lines? Are some of the lines actually un-doing stuff done previously? |
fdr
reviewed
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Add nvidia-cuda-toolkit to the GPU image (#2) Add nvidia-cuda-toolkit and cuda-drivers cuda-12-4 add cudnn add cudnn to env just install cudnn
velioglu
force-pushed
the
ubicloud
branch
2 times, most recently
from
July 4, 2024 16:05
efaa8a1
to
8d9a1bd
Compare
enescakir
force-pushed
the
ubicloud
branch
9 times, most recently
from
August 5, 2024 17:18
f3199e4
to
a07092f
Compare
enescakir
force-pushed
the
ubicloud
branch
3 times, most recently
from
August 15, 2024 18:52
ec985f6
to
38cbfc6
Compare
enescakir
force-pushed
the
ubicloud
branch
4 times, most recently
from
August 27, 2024 12:48
c72a177
to
28b6e86
Compare
enescakir
force-pushed
the
ubicloud
branch
3 times, most recently
from
October 7, 2024 12:51
b2adcd2
to
a597803
Compare
enescakir
force-pushed
the
ubicloud
branch
3 times, most recently
from
October 10, 2024 14:34
8aef658
to
c59a1c8
Compare
enescakir
force-pushed
the
ubicloud
branch
4 times, most recently
from
November 28, 2024 16:18
c2251a3
to
2a334b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each packer template has duplicate Ubicloud steps that we can extract into common script files. I've created this pull request for initial feedback. If it seems acceptable to you, I'll rebase my previous commits.