Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose method name in tchannel.CurrentCall #586

Open
prashantv opened this issue Feb 17, 2017 · 0 comments
Open

Expose method name in tchannel.CurrentCall #586

prashantv opened this issue Feb 17, 2017 · 0 comments

Comments

@prashantv
Copy link
Contributor

This is a little trickier than the others, since normally we just return the same *InboundCall object which satisfies the interface.

The *InboundCall object exposes method as Method() []byte and MethodString() string (for performance reasons).

If we wanted to reuse the *InboundCall object, we'd have to expose the methods as one of the above which seems a little hacky. Ideally we just expose Method() string, but this will require some internal refactoring, especially since we'll want to do this in a backwards compatible way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant