From e02e342eb51f11e530b9281b38b6a302eac9f706 Mon Sep 17 00:00:00 2001 From: Akshay Shah Date: Fri, 10 Jun 2016 17:04:41 -0700 Subject: [PATCH] Disable relaying in flaky test As mentioned in the pre-existing comment, enabling relaying makes this test flaky. We can re-enable once #390 is resolved. --- connection_test.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/connection_test.go b/connection_test.go index 71e6d4bb..5162f569 100644 --- a/connection_test.go +++ b/connection_test.go @@ -31,12 +31,13 @@ import ( "time" . "github.com/uber/tchannel-go" - - "github.com/stretchr/testify/assert" - "github.com/stretchr/testify/require" "github.com/uber/tchannel-go/raw" + "github.com/uber/tchannel-go/relay" "github.com/uber/tchannel-go/testutils" "github.com/uber/tchannel-go/testutils/testreader" + + "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" "golang.org/x/net/context" ) @@ -548,7 +549,7 @@ func TestWriteAfterConnectionError(t *testing.T) { // Closing network connections can lead to warnings in many places. // TODO: Relay is disabled due to https://github.com/uber/tchannel-go/issues/390 // Enabling relay causes the test to be flaky. - opts := testutils.NewOpts().DisableLogVerification() + opts := testutils.NewOpts().DisableLogVerification().NoRelay() testutils.WithTestServer(t, opts, func(ts *testutils.TestServer) { testutils.RegisterEcho(ts.Server(), nil) server := ts.Server()