Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Get rid of sync.Map #7

Open
zhijinli opened this issue Dec 22, 2017 · 0 comments · May be fixed by #13
Open

Get rid of sync.Map #7

zhijinli opened this issue Dec 22, 2017 · 0 comments · May be fixed by #13
Assignees
@zhijinli

Comments

@zhijinli
Copy link
Collaborator

zhijinli commented Dec 22, 2017 •
edited
Loading

If we replace the sync.Map (used by stateModelProcessors: https://github.com/uber-go/go-helix/blob/master/participant.go#L78) by a simple map and concurrency primitive (e.g. sync.Mutex), the library will be made available to a lot more users, since Go 1.9 that introduced sync.Map is still relatively new.

cc @zhixin @yulunli @syyang
@zhijinli zhijinli self-assigned this Dec 27, 2017
@zhijinli zhijinli linked a pull request Jan 5, 2018 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zhijinli zhijinli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

get rid of sync.Map for better go version compatibility uber-go/go-helix
1 participant
@zhijinli