Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure replacement values are properly quoted #110

Closed
wants to merge 1 commit into from
Closed

Ensure replacement values are properly quoted #110

wants to merge 1 commit into from

Conversation

jeromefroe
Copy link

Fixes #109

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #110 into master will decrease coverage by 0.43%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   93.77%   93.34%   -0.44%     
==========================================
  Files           9        9              
  Lines         418      421       +3     
==========================================
+ Hits          392      393       +1     
- Misses         16       17       +1     
- Partials       10       11       +1
Impacted Files Coverage Δ
expand.go 98.24% <50%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 773b542...ecd044c. Read the comment docs.

@prashantv prashantv requested a review from abhinav October 23, 2019 22:00
@jeromefroe
Copy link
Author

As @prashantv pointed out in #109 this approach will result in integer values being quoted also which isn't what we want. I'll look into the problem further to see if there is a solution we can find for both integers and strings that must be quoted.

@jeromefroe
Copy link
Author

This approach doesn't work and I was able to change the value in question in our case such that the new value doesn't need to be quoted.

@jeromefroe jeromefroe closed this Oct 24, 2019
@jeromefroe jeromefroe deleted the jeromefroe/ensure-environment-variables-are-properly-quoted branch October 24, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Ensure replacement values are properly quoted when necessary
1 participant