Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Codemode "replaceWith" value contains full path #9

Closed
dawsbot opened this issue Mar 9, 2017 · 1 comment
Closed

Codemode "replaceWith" value contains full path #9

dawsbot opened this issue Mar 9, 2017 · 1 comment
Assignees
Labels

Comments

@dawsbot
Copy link
Contributor

dawsbot commented Mar 9, 2017

Running instafork should not do codemod replacements with a full path: --replaceWith="/Users/dawsonbotsford/code/uberjs/src/@uber/react-button/dist/index.js"

Instead it should be: --replaceWith="./@uber/react-button/dist/index.js"

See #8

@dawsbot dawsbot self-assigned this Mar 9, 2017
@dawsbot dawsbot added the bug label Mar 9, 2017
@dawsbot
Copy link
Contributor Author

dawsbot commented Mar 9, 2017

Closed as invalid.

I forget about this "feature", but the codemod itself expects the full-path and then manages the relative path conversion on it's own. This is done because each file where the codemod acts could be at different places in the filesystem, so the logic for deciding the relative path lies in the codemod itself.

@dawsbot dawsbot closed this as completed Mar 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant