Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Add translations #38

Merged
merged 18 commits into from
Jun 27, 2023
Merged

Add translations #38

merged 18 commits into from
Jun 27, 2023

Conversation

ncovercash
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023 •
edited
Loading

Jest Unit Test Statistics

    1 files  ±0    74 suites  +2   8m 15s ⏱️ + 2m 11s
405 tests +4  405 ✔️ +4  0 💤 ±0  0 ❌ ±0 
443 runs  +4  443 ✔️ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 1d7db1f. ± Comparison against base commit 23fd35d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023 •
edited
Loading

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 1d7db1f. ± Comparison against base commit 23fd35d.

♻️ This comment has been updated with latest results.

@nhanaa
Copy link

nhanaa commented Jun 16, 2023

@ncovercash Seems like you already have a PR for this branch. I made the commit for the translations and sorting stuff. Lmk if anything is lacking.

This was linked to issues Jun 16, 2023
Add sorting to query results and localized dropdowns #23
Closed
Add full localization #27
Closed
ncovercash
ncovercash commented Jun 16, 2023
View reviewed changes
Copy link
Member Author

@ncovercash ncovercash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhanaa I can't mark this as a "proper" review since I made the PR, but a few comments. If you want, I can close this PR and you can re-make it, idc either way

src/components/AggregateCriteria/AggregateCriteriaCard.tsx Show resolved Hide resolved
translations/ui-plugin-bursar-export/en.json Outdated Show resolved Hide resolved
translations/ui-plugin-bursar-export/en.json Outdated Show resolved Hide resolved
translations/ui-plugin-bursar-export/en.json Outdated Show resolved Hide resolved
@nhanaa
Copy link

nhanaa commented Jun 16, 2023

@ncovercash I made a commit to address the issues.

ncovercash
ncovercash commented Jun 16, 2023
View reviewed changes
Copy link
Member Author

@ncovercash ncovercash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ncovercash
Copy link
Member Author

@nhanaa I'd write some tests for BursarExportPlugin and/or ConfigurationForm (even if it's just render and making sure it renders, which would be enough for ConfigurationForm; BursarExportPlugin would likely need some mocking/fancier tests but it's up to you if that's worthwhile)

@ncovercash
Copy link
Member Author

Also while you're in there @nhanaa , feel free to remove all those debug accordions and // TODO: add validate, at the bottom of ConfigurationForm

@nhanaa
Copy link

nhanaa commented Jun 26, 2023

@ncovercash

@ncovercash
Copy link
Member Author

@ncovercash

@nhanaa I don't see anything concerning (besides the smell for toSorted), everything looks fine

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@nhanaa nhanaa merged commit 58f98c5 into master Jun 27, 2023
@nhanaa nhanaa linked an issue Jun 27, 2023 that may be closed by this pull request
Create tests for ConfigurationForm and BursarExportPlugin #40
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danetsao danetsao danetsao left review comments

@nhanaa nhanaa nhanaa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ncovercash @nhanaa @danetsao