Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split repo is confusing, so combine issue tracker and source code repository again #3438

Closed
9 tasks done
rugk opened this issue Oct 31, 2024 · 2 comments
Closed
9 tasks done
Labels
declined declined invalid not a uBlock issue

Comments

@rugk
Copy link

rugk commented Oct 31, 2024

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

On gorhill/uBlock#3726 you wrote to split the issue tracker from the code (only) because:

Reason: the new issue tracker allows me to grant full permissions to volunteers in processing issues without having to grant full commit rights to code repository.

As of 2024 this is no longer needed, as GitHub allows for fine-grained controls, so only issue or code access e.g. can be given.

A specific URL where the issue occurs.

https://github.com/gorhill/uBlock/issues/3726

Steps to Reproduce

Visit https://github.com/gorhill/uBlock/ / gorhill/uBlock#3726

Expected behavior

Usually, I expect the issue tracker to be at the same location as the source code, everything else is also not intuitive and breaks workflows such as linking and closing issues from commits/PRs and vice versa.

Actually, the reason is no longer valid as explained above. See https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/managing-teams-and-people-with-access-to-your-repository for details.
One can also configure it for an org (uBlockOrigin seems be an org already): https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/managing-repository-roles/repository-roles-for-an-organization

BTW as for migrating, I'd propose to keep the issues here and just push the git repository (aka code) from the other one into here. This can be done with a few git commands. Then you can delete and rename the repositories (GitHub should keep redirects in place) and thus the way is not as hard. And you keep all old issues… (except from the old repository)

I mean you can also transfer issues (in an org) nowadays, but AFAIK only a single one at a time, so this would be time-consuming from clicks.

Actual behavior

The code and issue are separated. As said, this may break features and also confuses users/search engines (SEO) etc.

uBO version

N/A

Browser name and version

N/A

Operating system and version

N/A

@gorhill
Copy link
Member

gorhill commented Oct 31, 2024

I prefer to decline, I just don't have the time to spend on this. Things are working just fine the way it is for all involved here, there is no need to fix what is not broken.

@gorhill gorhill added the declined declined label Oct 31, 2024
@uBlock-user uBlock-user closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2024
@uBlock-user uBlock-user added the invalid not a uBlock issue label Oct 31, 2024
@garry-ut99

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
declined declined invalid not a uBlock issue
Projects
None yet
Development

No branches or pull requests

4 participants