-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element zapper does not function on Ublock origin, Firefox mobile. #3268
Comments
I just found out that there is an actual way to exit the element zapper, but it is not intuitive. |
This comment was marked as abuse.
This comment was marked as abuse.
Yes, something like the minimized picker bar could be helpful. I've also seen a number of people over the years ask for the persistent zapper mode on desktop (not being aware of achieving this with the [Del] shortcut). With the floating bar (or just a button) uBO could have consistent behavior in both places.
You're not the only one. I rarely ever use zapper myself. I'm quite sure I've encountered the same thing a few years back whilst investigating some reddit report. My first thought being maybe a bug caused by the website's CSS. @gorhill I'm leaving this open since the suggested solution is a valid one (IMO) and you've asked for suggestions in the older issue:
|
Del is still bugged e.g. if tab in browser lost focus - workaround: once remove with shift + mouse button and later by Del until lost focus (glitch). |
It would be wicked cool if there could be a small message popping up the first time a user uses the element zapper mode running on a mobile browser, pointing out those basic controls. Even just a one-time message with these bullet points would probably be sufficient:
I have to admit I never used the zapper mode on mobile, because I could never figure out how to make it work (navigation-wise, how to get out of it and save my changes), and wrote it off as "probably only works on desktops", and never bothered to look into it any further. |
Thanks for these tips |
Prerequisites
I tried to reproduce the issue when...
Description
The element zapper does not zap elements. When you open the uBlock Origin dialog from the extensions menu, and select the element zapper, it returns you to the previous webpage in element zapper as expected. However, while clicking on an element selects it, and clicking it again removes it, there is no way to exit the element zapper mode. You are permanently stuck removing elements until the page is reloaded, in which case all of the elements will come back again (expected behavior, but causes this to be a bug entirely preventing use of the element zapper.)
I have tested this on both Firefox nightly (128.0a1) and stable. A friend of mine has also tested it on his smartphone (unknown model and firefox version.)
A possible fix is to add a dialog at the bottom of the screen with a back or exit button, to allow the user to exit the element zapper mode.
A cleaner but likely impossible to implement fix would be to reuse android's back button to exit the element zapper.
A specific URL where the issue occurs.
https://thebestmotherfucking.website/
Steps to Reproduce
Install and launch Firefox mobile
Expected behavior
The element zapper works in a way that allows the user to exit the element zapping mode.
Actual behavior
The user becomes stuck in the element zapper until the page is reloaded.
uBO version
1.58.0
Browser name and version
Firefox Nightly 128.0a1 (Mobile)
Operating System and version
Android 14 aarch64 (Linux 4.19.278-g7b0944645172-ab1081281) Google Pixel 5, Stock ROM
The text was updated successfully, but these errors were encountered: