Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site styles break the picker frame #2075

Closed
5 tasks done
dimisa-RUAdList opened this issue Apr 2, 2022 · 6 comments
Closed
5 tasks done

Site styles break the picker frame #2075

dimisa-RUAdList opened this issue Apr 2, 2022 · 6 comments
Labels
bug Something isn't working external issue involving an external factor Firefox specific to Firefox

Comments

@dimisa-RUAdList
Copy link

dimisa-RUAdList commented Apr 2, 2022

Prerequisites

  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • The issue is not present after wholly disabling uBlock Origin ("uBO") in the browser
  • I checked the documentation to understand that the issue I report is not a normal behavior

I tried to reproduce the issue when...

  • uBO is the only extension
  • using a new, unmodified browser profile

Description

Site styles break the picker frame

See: view-source:https://www.opennet.ru/

html.dark-mode { filter: invert(90%); background-color: black; } html.dark-mode img:not([src*="opennet2"]), video, iframe{ filter: invert(100%); }

A specific URL where the issue occurs

https://www.opennet.ru/~

Steps to Reproduce

  1. Open https://www.opennet.ru/~
  2. On dark-mode: https://i.imgur.com/9b3bUhV.jpg
  3. Open https://www.opennet.ru/ and try using the picker
  4. Scroll down the page

Expected behavior

Picker works as usual

Actual behavior

The picker's frame is broken - its positioning is broken, the color scheme may change

Configuration

uBlock Origin: 1.42.0
Firefox: 98
filterset (summary): 
  network: 99248
  cosmetic: 89614
  scriptlet: 18198
  html: 635
listset (total-discarded, last updated): 
  added: 
    fanboy-cookiemonster: 27670-53, 20h.29m
    ublock-quick-fixes: 123-4, 1m
  default: 
    user-filters: 6-0, never
    ublock-filters: 31051-36, 1m
    ublock-badware: 4011-3, 1m
    ublock-privacy: 211-0, 1m
    ublock-abuse: 72-0, 1m
    ublock-unbreak: 1741-0, 1m
    easylist: 65125-588, 20h.29m
    easyprivacy: 26744-580, 1m
    urlhaus-1: 7399-0, 1m
    plowe-0: 3687-2, 1m
    RUS-0: 41482-164, 1m
filterset (user): [array of 8 redacted]
trustedset: 
  added: [array of 2 redacted]
  removed: 
    edge-scheme
    moz-extension-scheme
switchRuleset: 
  removed: 
    no-csp-reports: * true
modifiedUserSettings: 
  advancedUserEnabled: true
  showIconBadge: false
modifiedHiddenSettings: 
  filterAuthorMode: true
  uiFlavor: classic
supportStats: 
  allReadyAfter: 1113 ms
  maxAssetCacheWait: 495 ms
@krystian3w
Copy link

krystian3w commented Apr 3, 2022

#987 (comment)

So we wait with pages where iframe was rotated by transform: rotate(180deg) or rotate: 180deg.

@gwarser gwarser added the bug Something isn't working label Apr 4, 2022
gorhill added a commit to gorhill/uBlock that referenced this issue Apr 4, 2022
@gorhill
Copy link
Member

gorhill commented Apr 4, 2022

I could reproduce the filter: invert(), which I fixed, but I could not reproduce "positioning is broken".

@krystian3w
Copy link

krystian3w commented Apr 4, 2022

That is glitch in Firefox (no in Chromium) after use css filters - no longer works position:

  • Fixed
  • Absolute
  • maybe Sticky and relative too.

https://developpaper.com/explain-the-reasons-and-solutions-of-the-conflict-between-filter-and-fixed-in-detail/

@dimisa-RUAdList
Copy link
Author

dimisa-RUAdList commented Apr 4, 2022

@gorhill
"positioning is broken":

opennet_picker.mp4

@krystian3w
Copy link

krystian3w commented Apr 4, 2022

Reupload into Github domain if you no block my ID in network filters:

https://user-images.githubusercontent.com/35370833/161556381-c466341a-9546-41e3-8d05-03525cdddc5e.mp4

Guilty is filter on html element (mother page).

html.dark-mode { filter: invert(90%); background-color: black; } 

Workarounds due similar troubles to: #419 is:

  • use browser without bug positioning (All Chromium family, I suppose Safari 11 too).
  • save in my filters tab filter to disable almost all tries to use filter by page.
  • don't enable harmful implementation dark mode by filters insted change few colors in layout.

@gorhill
Copy link
Member

gorhill commented Apr 4, 2022

Ok the position issue is specific to Firefox, I can't fix that in uBO. Also since the filter is also set on the root element, not something I can fix in uBO. What I fixed is the element picker being rendered as dark theme when not toggling the page to dark.

@gwarser gwarser added external issue involving an external factor Firefox specific to Firefox labels Apr 17, 2022
@gwarser gwarser closed this as completed Apr 17, 2022
@ghost ghost mentioned this issue Apr 28, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external issue involving an external factor Firefox specific to Firefox
Projects
None yet
Development

No branches or pull requests

4 participants