-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element picker can be covered by native <dialog>
/ [popover]
pop-ups
#2027
Comments
Doesn't gorhill decline issues based just on proof on concept instead or real cases? |
Maybe but what happens when these pop-ups start cover 99% of Internet or start used to disable use element picker (small ads in sidebar without backdrop). |
Pages started use dialogs: |
My bad. I was still on FF 97.0.2 and wasn't affected. |
If I understood this issue correctly, the same behavior can be seen on this link:
The picker won't become visible. Caused by GDPR dialog. |
I see similar behaviour with a consent dialog at https://computerbase.de. My workaround is to manually enter a filter rule that blocks dialogs, like so:
The funny thing about this is that using a dialog element makes blocking the whole consent mechanism much cleaner and easier. But it would be nice if the element picker could handle it. (Of course, blocking all dialog elements is an extreme solution and not an option if the site uses dialogs for anything that's actually useful to the user, but the filter can be made more granular with class designators.) |
Worse as they will drive us into a corner when the attribute name is not stable and the value is - not everyone has yet learned to use |
<dialog>
pop-ups
Popover also is danger:
test: https://gistcdn.githack.com/krystian3w/4ebb7b77634d94a9b2f7238dcee32947/raw/index2.html (On the plus side of the attribution is the requirement for a genuine click (only someone needs to check that they detect fake clicks in JS - if there is no detection of whether the user has clicked, I would equate it with the dialogue tag)) |
<dialog>
pop-ups<dialog>
/ [popover]
pop-ups
If the dialog is modal (shown with |
This comment was marked as off-topic.
This comment was marked as off-topic.
@dftf-stu Concerning that matter, please open a separate discussion thread here: https://github.com/uBlockOrigin/uBlock-issues/discussions |
Prerequisites
I tried to reproduce the issue when...
Description
New native dialog pop-ups is rendered higher than element picker iframe, so if element is selected then no possible click in "create" button. Similar to #1098, #987
AdGuard freeware Addon have similar limitation as long use iframe
#adguard-assistant-dialog
.A specific URL where the issue occurs
https://gistcdn.githack.com/krystian3w/4ebb7b77634d94a9b2f7238dcee32947/raw/index.html or https://gistcdn.githack.com/krystian3w/4ebb7b77634d94a9b2f7238dcee32947/raw/index2.html
real world cases:
https://www.blogmojo.de/chatgpt-alternative/
indagare.com
computerbase.de
https://en-us.topographic-map.com/map-vx51/San-Francisco/?center=37.90303%2C-121.83254&zoom=12
https://www.warzywapolowe.pl/
Steps to Reproduce
Expected behavior
z-index: auto
so I cannot found method)Actual behavior
uBlock Origin version
1.58.1b12
Browser name and version
Firefox 128.0
Operating System and version
Windows 11 Pro 23H2
The text was updated successfully, but these errors were encountered: