Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple demo does not work #5

Open
MichalBryxi opened this issue Sep 9, 2023 · 6 comments · May be fixed by #14
Open

Simple demo does not work #5

MichalBryxi opened this issue Sep 9, 2023 · 6 comments · May be fixed by #14
Assignees
@tzellman

Comments

@MichalBryxi
Copy link

Reproduction repo

Steps to reproduce manually

  1. Bootstrap new app:
EMBER_CLI_PNPM=true ember new ember-heroicons-bugreport --skip-npm --pnpm=true --typescript=true
  1. Install ember-heroicons:
ember install ember-heroicons
  1. Try to render any HeroIcon component:
<HeroIcon @icon="check-circle" />
  1. See that respective place where hero icon should be is empty:
<p>
  -- START --
</p>
<svg>
    
</svg>
<p>
  -- END --
</p>
@tzellman tzellman self-assigned this Sep 9, 2023
@tzellman
Copy link
Owner

tzellman commented Sep 9, 2023

I'll try to look into this soon. One thing to note: I don't believe I have tested with Ember 5.x yet. I also have not tested with pnpm. If you end up having more time to investigate, a PR is welcome! Thanks!

@MichalBryxi
Copy link
Author

Turns out it's a dependency issue. Following:

pnpm install --save-dev heroicons

Will solve it in my bugreport repro app.

Now the question is: Can it be so that the heroicons package will be installed / pulled in automagically when ember-heroicons is installed?

@MichalBryxi
Copy link
Author

MichalBryxi commented Sep 10, 2023 •
edited
Loading

Oh and re the v5: When I install this package I get a warning that peer deps are broken because of version of ember. Might be also worth bumping. Reported as #6.

@MichalBryxi
Copy link
Author

Ha! I just got bitten by this again and found my original fix that is still working :)

@jagthedrummer jagthedrummer mentioned this issue Mar 25, 2024
Open
@MichalBryxi
Copy link
Author

MichalBryxi commented Apr 22, 2024 •
edited
Loading

Thinking out loud: I think that this is the original idea between peerDependencies. So I think adding heroicons package to package.json here should be the solution?

cc: @tzellman

MichalBryxi added a commit to MichalBryxi/ember-heroicons that referenced this issue Apr 22, 2024
@MichalBryxi
fix: Make heroicons a peerdep
aab2776 
- Fixes tzellman#5
- Well it does not _fix_ it, but at least it will give the user hint during `pnpm install` that there is something missing
@MichalBryxi MichalBryxi linked a pull request Apr 22, 2024 that will close this issue
Open
@IgnaceMaes
Copy link

Turns out it's a dependency issue. Following:

pnpm install --save-dev heroicons

Will solve it in my bugreport repro app.

Now the question is: Can it be so that the heroicons package will be installed / pulled in automagically when ember-heroicons is installed?

Migrated one repo to pnpm and found the icons were missing in the production build. This did the trick, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzellman tzellman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Make heroicons a peerdep MichalBryxi/ember-heroicons
3 participants
@tzellman @MichalBryxi @IgnaceMaes