Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate RoutingService functionality #487

Open
spockz opened this issue Feb 10, 2019 · 1 comment
Open

Isolate RoutingService functionality #487

spockz opened this issue Feb 10, 2019 · 1 comment

Comments

@spockz
Copy link

spockz commented Feb 10, 2019

An interesting part of Finatra is how it builds on top of Finagle to do routing of (external) services. This is available in com.twitter.finatra.http.internal.routing.RoutingService which is internal.

Expected behavior

Able to use the RoutingService from Scala without any dependencies on twitter server or others.

Actual behavior

Currently the RoutingService is not available in Scala because it is internal/package private to http. The java compiler doesn't care (becomes it becomes public in jvm bytecode anyway.). Additionally, it is part of the http package which drags in a whole slew of other dependencies.

The benefit of the RoutingService in Finatra over the one in Finagle is that the Finagle one doesn't support path parameters.

@cacoco
Copy link
Contributor

cacoco commented Feb 13, 2019

@spockz thanks for the issue, we'll take a look into what we can do.

@cacoco cacoco added the backlog label Apr 9, 2019
@cacoco cacoco added this to the 20.3.0 milestone Oct 29, 2019
@enbnt enbnt removed their assignment Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants