Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some comments #397

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix some comments #397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/twirptest/service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,7 +697,7 @@ func TestErrorWithRetryableMeta(t *testing.T) {
}

if twerr.Meta("retryable") != "true" {
t.Errorf("expected error to be retryable, but it isnt")
t.Errorf("expected error to be retryable, but it isn't")
}
if twerr.Msg() != eMsg {
t.Errorf("expected error Msg to be %q, but found %q", eMsg, twerr.Msg())
Expand Down Expand Up @@ -1551,7 +1551,7 @@ func (errReader) Read(p []byte) (n int, err error) {

// Test failures when reading the request.
// The request could be incomplete because the client timed out, which in most cases is signaled by
// a context cancelation or timeout. In those cases, the twirp handled would properly identify and return those errors.
// a context cancellation or timeout. In those cases, the twirp handled would properly identify and return those errors.
func TestRequestBodyError(t *testing.T) {
type contextUpdate func(ctx context.Context) (context.Context, context.CancelFunc)
testCases := []struct {
Expand Down