Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: TwilioConversationsClient crashes on Initialize a new conversations client instance with an expired jwt token. #60

Open
haithngn opened this issue Jul 4, 2024 · 0 comments
Labels
category:bug disposition:triage The bug requires triage

Comments

@haithngn
Copy link

haithngn commented Jul 4, 2024

SDK version

4.0.3

Device model

iPhone/Any Model

OS version

Any OS version

Issue description

We have faced this crash on the Twilio SDK, we tried too many ways to find the rootcause for a long time because the crash log doesn't help.

Now we found one reason is the JWT token which is passed into method conversationsClient was expired and caused the crash.

TwilioConversationsClient.conversationsClient(withToken: acessToken, properties: properties, delegate: 

We can avoid the crash by pre-check the token expiration before invoking the method.

IMHO, the client should throw an error/exception via the delegate method or completion block args instead.

cc: @berkus

@haithngn haithngn added category:bug disposition:triage The bug requires triage labels Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bug disposition:triage The bug requires triage
Projects
None yet
Development

No branches or pull requests

1 participant