Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset Context Selection When Navigating Between Indexes #9132

Open
Bonapara opened this issue Dec 18, 2024 · 2 comments · May be fixed by #9140
Open

Reset Context Selection When Navigating Between Indexes #9132

Bonapara opened this issue Dec 18, 2024 · 2 comments · May be fixed by #9140
Labels
prio: med

Comments

@Bonapara
Copy link
Member

Current behavior

When navigating to another index, the selection context is kept into memory (When I navigate through a show, as clicking outside a table remove the context)

Enregistrement_de_lecran_2024-12-18_a_18.05.18-1.mov
CleanShot_2024-12-18_at_17.53.40.mov

Desired Behavior

We should reset the context selection. No records should be selected when coming back on an index
@samyakpiya
Copy link
Contributor

I'd like to work on this issue. I'm implementing a solution using RecordIndexResetSelectionEffect to clear the selection state when navigating away from the index page.

@samyakpiya samyakpiya linked a pull request Dec 19, 2024 that will close this issue
Open
@samyakpiya
Copy link
Contributor

I've created a PR that fixes this issue: #9140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio: med
Projects
Product development ✅
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reset table selection when navigating away from index page samyakpiya/twenty
2 participants
@Bonapara @samyakpiya