New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If attachment token expires, it throws a 500 error instead of Unauthenticated #8825

Closed

janwo opened this issue Dec 1, 2024 · 6 comments · Fixed by #9043

Assignees

Labels

good first issue

janwo commented Dec 1, 2024

Bug Description

If attachment token expires, it throws a 500 error instead of Unauthenticated (http://localhost:3000/files/attachment/6e007a40-8da7-442a-a206-1de7a04a087f.png?token=xxx)

Expected behavior

I would expect an unauthenticated error or something more descriptive to distinguish from unexpected server errors.

github-project-automation bot added this to Product development ✅

github-project-automation bot moved this to 🆕 New in Product development ✅

FelixMalfait added the good first issue label

giiger commented Dec 2, 2024

Could I be assigned to this? I am a new contributor :)

Member

FelixMalfait commented Dec 4, 2024

@giiger yes of course! Thank you!

FelixMalfait assigned giiger

giiger commented Dec 6, 2024

Contributor

munch-lax commented Dec 10, 2024

Hey @FelixMalfait @janwo, I'd like to work on this bug. Does the current PR address your requirements? If not, I'd love to give it a shot!

Member

FelixMalfait commented Dec 12, 2024

@munch-lax it doesn't address the requirements unfortunately. We'll merge whichever gets it right. Thanks a lot to both of you!

Contributor

munch-lax commented Dec 12, 2024 •

edited

Loading

@FelixMalfait PR-9043

FelixMalfait mentioned this issue

Fix : #8825 If attachment token expires, it throws a 500 error instead of Unauthenticated #9043

Merged

charlesBochet closed this as completed in #9043

charlesBochet closed this as completed in

d324cac

github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment