I should be able to filter on workspaceMember = me

[FelixMalfait]

Context

In #7196 we introduce "variable filters" such as "today" or "in the future", in which the frontend dynamically replaces the value before throwing the query.

Current behavior

Desired behavior

We would like to introduce a "current user" option for workspaceMember relations, for example assignee on Tasks.

See how Linear is also doing it:

Figma

• Change no owner icon to circle-dashed-x
• The text for "is empty" should be no field-name e.g no owner, no assignee...
• Create a new me value with user-circle icon

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=43752-81861&node-type=instance&t=tFDldeynurqAJQpp-11

[sanjay-gangwar4410]

/assign

[oss-gg]

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

[ketanMehtaa]

assign me if sanjay is not working on this .

[sanjay-gangwar4410]

i am not working on it . you (@ketanMehtaa )can work on it

[FelixMalfait]

/oss.gg 1000

[oss-gg]

Thanks for opening an issue! It's live on oss.gg!

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[NabidAkhtar]

@sanjay-gangwar4410 please unassign yourself, if you are not working.

[antilpiyush89]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[DanishAliUmar]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[prithak01]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[eliasylonen]

Some rubber ducking / notes:

I need to add something like CURRENT_WORKSPACE_MEMBER as a possible filter value for RELATION filters, and convert it into a workspace member id in resolveFilterValue.

To do this, resolveFilterValue needs to know the id of current workspace member.

I think passing currentWorkspaceMemberId to resolveFilterValue as a parameter is not a very elegant long-term solution, because resolveFilterValue might need many more similar parameters in the future when more "variable" filters (like PAST_3_WEEKS for DATE filters and CURRENT_WORKSPACE_MEMBER for RELATION filters) are added.

I think it would be good to wrap resolveFilterValue with a hook (e.g. useResolveFilterValue) to avoid having to supply all its dependencies as parameters.

---

TODO - continuing here tomorrow: Is there any reason against wrapping all functions where resolveFilterValue is used with hooks to be able to use the useResolveFilterValue hook inside them? Probably no.

---

In the long term I think the most elegant solution would be to call the useResolverFilterValue hook as early as possible: The current Filter type could be changed to contain the resolved filter value instead of the unresolved value from the original ViewFilter. That way filtering-related components would not have to do any value resolving at all, they could just always use the resolved value.

Downside: That would be a bigger refactoring than I first thought.

[FelixMalfait]

Thanks @eliasylonen!

[lucasbordeau]

@eliasylonen We most probably shouldn't work at this abstraction level and instead focus on trying to turn every specific hard coded case into a generic record filter so that all this low-level generic logic isn't aware of anything we're doing above it.

CURRENT_WORKSPACE_MEMBER is just something high level to indicate that we want to add a filter id on workspaceMember, which is something generic that can be stored as a filter like anything related to this in the future.

We should work on something like an adapter that turns everything into a generic record filter

[eliasylonen]

I'll refactor filtering to work like this:

1. Get view filters from backend.
2. Create a recoil selector that returns two arrays: variable filters and static filters.
3. Use variable filters and static filters in components as needed.
4. Convert static filters into a GraphQL query.

[eliasylonen]

@lucasbordeau
Some context for today's call, but no need to prep! I have a list of questions ready

Filter value resolution in object filter component:
eliasylonen@354c94a

Passing current workspace member id to the util function that generates the GraphQL query - I think a hook would be better?
eliasylonen@d86416a