When creating new People object, data from First/Last Name is lost after clicking on First/Last Name field

[BOHEUS]

Scenario:

1. Log in
2. Go to People
3. Click on '+' in right top corner
4. Enter anything in First name and click on Last name field

Actual: Data inserted in First name field disappears after clicking on Last name field (on video it's clear that after inserting data in both name fields and clicking on any of them, it disappears)
Screencast from 2024-08-26 12-17-50.webm

Expected: Data must stay in First name field

Note: Problem doesn't appear when entering data in First name field and clicking Tab in order to move to Last name field

[harshit078]

Seems like the current state is not getting saved as when you press Enter or Tab or click outside it saves the new cell when you switch from first name or last name. However when you attempt to rename the cell then it works normally.

[Nabhag8848]

Related and has same issue as in #6633 draftValue is getting reset when we tap on it while having state in other field. I'm handling it in PR #6736 as this particular thing will need to fix first inorder to also handle that whitespace in both - fullName field shouldn't create record.

[Nabhag8848]

Hey @harshit078 would you like to tackle this ? as I was able to test this without solving as you mentioned this isn't happening with tab or shift + tab, I haven't handle it yet.

I can help you to get your PR first contribution, right at this line just console.log(draftValue) this is getting undefined when we tap on it this can be starting point to find out whats the core issue and as always things can get complicated.

twenty/packages/twenty-front/src/modules/object-record/record-field/meta-types/input/components/FullNameFieldInput.tsx

Line 31 in 1d6a1f6

const { hotkeyScope, draftValue, setDraftValue } = useFullNameField();

also this commit in my pr #6736 are changes to this file 3ba10ae

[harshit078]

Sure @Nabhag8848, Will take this up no issue.

[charlesBochet]

Thank you guys!

[Bonapara]

@harshit078 are you still willing to take this up? If yes I will assign you. Thanks for contributing!

[harshit078]

On debugging, It can be seen that const draftValue = useRecoilValue(getDraftValueSelector()); is the place where draftValue is being undefined. However recordId, fieldName and scopeId all are defined and are being not passed as NULL. Since draftValue is undefined then through nullish operator we should get the empty string operator but firstValue is still being passed the draftValue firstValue={draftValue?.firstName ?? ''} & secondValue={draftValue?.lastName ?? ''} . If we only pass '' in both first and second Value, this issue resolved itself as can be seen in the attached video. What are your opinions on this ?

Screen.Recording.2024-08-29.at.2.26.44.AM.mov

[Bonapara]

@lucasbordeau will have a thought for your @harshit078. Thanks for tackling it!

[harshit078]

Also this only happens when creating a new cell for the first time. When a cell already created and then if you edit the first name or last name, then it saves the current state.

Screen.Recording.2024-08-31.at.2.09.57.AM.mov

[charlesBochet]

@lucasbordeau can you investigate this one?

draftValue should not be reset once we are still in the open cell

[lucasbordeau]

@harshit078 I'll fix it rapidly.