-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default country for phone numbers should be defined at the field level #4952
Comments
Here is the GitStart Ticket for this issue: https://clients.gitstart.com/twenty/5449/tickets/TWNTY-4952 |
Hey @FelixMalfait, Just to confirm, we're converting the phone field from a string to a composite that will also include the The address is already a composite that includes the countryCode, we just need to add the country picker for it. If yes, are we also handling migrating the current phoneNumbers to this new type? Cheers! |
@gitstart-twenty since you have tackled #6882 you should be able to pickup this one now |
Closing this as it's not that relevant. It seems the default country isn't France anymore but has been left as blank which is fine! |
Just noticed we assumed by default the country is FR which is wrong. We should be be able to set the default country at the field level and/or at the address level. Same for the address field - we should introduce a country dropdown with a similar default value.
https://github.com/twentyhq/twenty/blob/main/packages/twenty-front/src/modules/ui/field/display/components/PhoneDisplay.tsx
Also the default country should be the US not FR.
The text was updated successfully, but these errors were encountered: