Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grepdiff1 test fails on musl #61

Open
alyssais opened this issue Apr 25, 2024 · 2 comments
Open

grepdiff1 test fails on musl #61

alyssais opened this issue Apr 25, 2024 · 2 comments

Comments

@alyssais
Copy link

musl does not accept the regex \+a used in the grepdiff1 test. + doesn't have special meaning in POSIX regular expressions if it's at the start of the expression. So the POSIX way to write that regular expression would be +a.

However, this is actually what the test used to do, until it was changed in a653875 with no explanation given. What was the motivation for that change?

@twaugh
Copy link
Owner

twaugh commented Apr 26, 2024

I don't remember :(

I wonder if that test is still useful. WDYT?

@alyssais
Copy link
Author

It looks like grepdiff has lots of other test coverage? But I'm not too familiar with what it even does — I'm mostly interested in patchutils for filterdiff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants