Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File permissions/flags are ignored by filterdiff #59

Open
Tracked by #266556
pbsds opened this issue Nov 10, 2023 · 3 comments
Open
Tracked by #266556

File permissions/flags are ignored by filterdiff #59

pbsds opened this issue Nov 10, 2023 · 3 comments

Comments

@pbsds
Copy link

pbsds commented Nov 10, 2023

It seems filterdiff ignores changes in file permissions, such as removal of the executable flag.

Repro:

curl 'https://github.com/NationalSecurityAgency/ghidra/commit/e2a945624b74e5d42dc85e9c1f992315dd154db1.patch' | filterdiff

Expected result

A diff

Actual result

Nothing

@sergiomb2
Copy link
Contributor

sergiomb2 commented Feb 6, 2024

is a feature not a bug "This way filterdiff can be used to clean up an existing diff file, removing redundant lines
from the beginning (eg. the text from the mail body) or between the chunks (eg. in CVS diffs). To extract pure patch data"

@pbsds
Copy link
Author

pbsds commented Feb 6, 2024

Not considering file permission changes (nor renames? #22) a part of the "patch data" strikes me as kind of arbitrary, and is unfortunate since it breaks the assumption that a filtered diff would apply the same changes as the original diff.

@sergiomb2
Copy link
Contributor

correct filterdiff clean renames and file permissions modifications from the patch , is a almost an duplicate issue of #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants