Add " Interface IP" display capability + More modern CSS style #25

benjisho · 2024-06-12T15:21:26Z

Summary

This pull request enhances the tcgui project by adding the capability to display the IP addresses of each interface and updating the CSS to a more modern style.

Changes

Interface IP Display:
- Modified the Flask application to fetch and display IP addresses alongside interface names.
- Updated the HTML templates to incorporate IP addresses next to interface names in all relevant sections.
CSS Update:
- Updated the CSS to improve the visual style, making it more modern and user-friendly.

Benefits

Enhanced Usability: Users can now easily see the IP addresses of each network interface directly in the web UI, improving the usability and convenience of the tool.
Modern Look: The updated CSS provides a cleaner and more modern look, enhancing the overall user experience.

Screenshots

Before:

After:

Testing

Verified that the IP addresses are correctly fetched and displayed for each interface.
Confirmed that the updated CSS renders correctly across various browsers.

- Improved the overall layout and styling of the interface table. - Added a cleaner and modern design using CSS. - Ensured all interfaces are displayed and properly aligned. - Added hover effects for buttons to enhance interactivity. - Updated the color scheme for better readability and aesthetics. - Maintained functionality while improving visual appeal.

hofbi

Thanks for your contributions, I really like the new style of the app!

main.py

static/pure-min.css

TheLoneDev · 2024-06-13T09:54:03Z

Oh wow, I use TC and I really like the new design

Co-authored-by: Markus Hofbauer <[email protected]>

benjisho · 2024-06-16T09:16:50Z

Changes were applied, let me know what you think :)

hofbi

Last small comment, then we are ready to merge.

main.py

Display of IP addresses started causing issues after last edit, had to rollback to my initial contribution so UI will display IP correctly

hofbi · 2024-07-03T17:39:45Z

@benjisho regarding the last rollback, could you please try subprocess.run? see https://stackoverflow.com/a/39187984 as a reference. It looks like we mainly care about running the command and getting the output back.

use subprocess.run instead of subprocess.Popen for retrieving IP

benjisho · 2024-07-12T10:20:53Z

I have replaced subprocess.Popen with subprocess.run for retrieving IP addresses and also decided to add a bit error handling to it, please let me know what you think

hofbi · 2024-07-12T15:03:46Z

Looks good to me. Almost ready to merge. Let's just replace the old image with the new one. No need to keep the old image.

benjisho · 2024-07-19T22:16:24Z

seems that CI is now failing because isort packege

hofbi · 2024-07-19T22:23:56Z

I can take a look on Monday.

If you want to take some action, you could create a separate PR where you do a pre-commit autoupdate and then pre-commit run -a and commit these changes. If you encounter some failures it might be because Python 3.8 is no longer supported by the most recent hooks. So we might have to update to Python 3.10.

.pre-commit-config.yaml

hofbi

Last small comment before we can merge

hofbi · 2024-07-22T08:36:12Z

main.py

+        result = subprocess.run(
+            ["ip", "-o", "-4", "addr", "show"],
+            capture_output=True,
+            text=True,
+            check=True,
+        )
+        output = result.stdout


These lines are duplicated from above, can we make it a seperate one and reuse in both places

added new run_ip_command function to handle this

benjisho · 2024-08-10T06:45:10Z

@hofbi Seems tha CI is failing due to pre-commit update of package pyupgrade
The new version of pyupgrade is requiring the user to use python version 3.9 or above, while ci.yml is using python 3.8.

Can we ignore the issue? or shall we change the ci.yml to use python 3.9 or above?

hofbi · 2024-08-10T07:37:51Z

To finally get this PR merged, I suggest we downgrade pyupgrade to 3.16 which is the last version supporting python 3.8

Upgrading the entire thing would be a follow up PR. Here we could add support for Ubuntu 22.04 by switching to Python 3.10.

benjisho added 4 commits June 12, 2024 18:09

add display of interface ip capability - in main.py

7c97550

add display of interface ip capability - in main.html

8ae50a8

add improved css style - in pure-min.css

024be5b

hofbi reviewed Jun 12, 2024

View reviewed changes

main.py Outdated Show resolved Hide resolved

main.py Outdated Show resolved Hide resolved

main.py Outdated Show resolved Hide resolved

static/pure-min.css Outdated Show resolved Hide resolved

benjisho and others added 5 commits June 16, 2024 11:02

Update main.py

c16096e

Co-authored-by: Markus Hofbauer <[email protected]>

add if match else "No IP found" - main.py

297601f

Co-authored-by: Markus Hofbauer <[email protected]>

rename css file to gui_styles.css

a8991eb

remove old file

491dd70

add suggestion for stdout decode

241c412

hofbi reviewed Jun 16, 2024

View reviewed changes

main.py Outdated Show resolved Hide resolved

rolled back proc and output separation main.py

93235ff

Display of IP addresses started causing issues after last edit, had to rollback to my initial contribution so UI will display IP correctly

benjisho added 2 commits July 12, 2024 13:16

Replace Popen with subprocess.run

461467a

use subprocess.run instead of subprocess.Popen for retrieving IP

Add error handling to get_interfaces functions

343233f

Add new GUI screenshot to the readme

74f6efb

Delete tcgui.png

f157995

benjisho closed this Jul 19, 2024

benjisho deleted the patch-1 branch July 19, 2024 20:41

benjisho mentioned this pull request Jul 19, 2024

Add " Interface IP" display capability + More modern CSS style #26

Closed

benjisho restored the patch-1 branch July 19, 2024 22:11

benjisho reopened this Jul 19, 2024

benjisho added 2 commits July 20, 2024 12:45

run - pre-commit autoupdate

371acaf

add setuptools dependency for pre-commit run -a failure

0d4928d

benjisho added 2 commits July 20, 2024 12:55

lines added by pre-commit run -a

87a97b6

network troubleshooting tools added to Dockerfile for net testing

08c2123

hofbi reviewed Jul 22, 2024

View reviewed changes

.pre-commit-config.yaml Outdated Show resolved Hide resolved

Update .pre-commit-config.yaml

d451fd4

hofbi reviewed Jul 22, 2024

View reviewed changes

benjisho added 4 commits August 2, 2024 22:09

add docker-compose documentation

b343e5e

fix - Correctly retrieve IP addresses for network interfaces

d67de2a

default: network_mode: host

cc89d3a

Remove redundancy in IP command execution

5a34203

hofbi approved these changes Aug 3, 2024

View reviewed changes

benjisho added 3 commits August 3, 2024 12:12

run pre-commit autoupdate

bc0c55d

fixes by pre-commit run -a

f1977bb

pre-commit autoupdate

96c1470

pyupgrade downgrade to 3.16 due to python 3.8 dependency

8d49c2b

hofbi merged commit e996853 into tum-lkn:master Aug 11, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add " Interface IP" display capability + More modern CSS style #25

Add " Interface IP" display capability + More modern CSS style #25

benjisho commented Jun 12, 2024 •

edited

Loading

hofbi left a comment

TheLoneDev commented Jun 13, 2024

benjisho commented Jun 16, 2024

hofbi left a comment

hofbi commented Jul 3, 2024 •

edited

Loading

benjisho commented Jul 12, 2024

hofbi commented Jul 12, 2024

benjisho commented Jul 19, 2024

hofbi commented Jul 19, 2024

hofbi left a comment

hofbi Jul 22, 2024

benjisho Aug 2, 2024

benjisho commented Aug 10, 2024

hofbi commented Aug 10, 2024

Add " Interface IP" display capability + More modern CSS style #25

Add " Interface IP" display capability + More modern CSS style #25

Conversation

benjisho commented Jun 12, 2024 • edited Loading

Summary

Changes

Benefits

Screenshots

Before:

After:

Testing

hofbi left a comment

Choose a reason for hiding this comment

TheLoneDev commented Jun 13, 2024

benjisho commented Jun 16, 2024

hofbi left a comment

Choose a reason for hiding this comment

hofbi commented Jul 3, 2024 • edited Loading

benjisho commented Jul 12, 2024

hofbi commented Jul 12, 2024

benjisho commented Jul 19, 2024

hofbi commented Jul 19, 2024

hofbi left a comment

Choose a reason for hiding this comment

hofbi Jul 22, 2024

Choose a reason for hiding this comment

benjisho Aug 2, 2024

Choose a reason for hiding this comment

benjisho commented Aug 10, 2024

hofbi commented Aug 10, 2024

benjisho commented Jun 12, 2024 •

edited

Loading

hofbi commented Jul 3, 2024 •

edited

Loading