Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMI bug #879

Open
ar13pit opened this issue Jul 11, 2019 · 5 comments
Open

HMI bug #879

ar13pit opened this issue Jul 11, 2019 · 5 comments
Assignees

Comments

@ar13pit
Copy link
Contributor

ar13pit commented Jul 11, 2019

  1. New request must not to be sent to the clients until a response from the previous is received.
  2. Before sending a new request, a preempt request must be sent to all active clients processing the previous request.
  3. The clients must send a status of the preempt request and if no such request is received by the server, then respawn those clients.

If this is not done then grammar memory is fucked!

@ar13pit ar13pit self-assigned this Jul 11, 2019
@MatthijsBurgh
Copy link
Member

These are all action clients, so should be possible. I am not so sure about the respawning. Maybe some action id checks might help.

@Rayman
Copy link
Member

Rayman commented Jul 12, 2019

I think in principle the first 2 points you mentioned are implemened here, but there could be a bug. The main loop is single threaded. All requests are handled before a new request is received.

Idea's

  • After clients are cancelled, there is no confirmation if the cancellation succeeded (wait_for_result)
  • ???

@ar13pit
Copy link
Contributor Author

ar13pit commented Jul 12, 2019

Still needs testing though, just to be sure. And then we need to put docs in it so that we don't end up looking into this again.

@LarsJanssenTUe
Copy link
Contributor

@ar13pit what do you want to do with this?

@ar13pit
Copy link
Contributor Author

ar13pit commented Mar 31, 2020

This will be checked in the coming weeks when we are testing the grammar construction for speech recognition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants