Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SDF test #13

Open
MatthijsBurgh opened this issue Apr 2, 2019 · 0 comments
Open

Refactor SDF test #13

MatthijsBurgh opened this issue Apr 2, 2019 · 0 comments

Comments

@MatthijsBurgh
Copy link
Member

Simplest way to fix is to create a clean new object for each test, and then get it in the proper state for each test by calling whatever previous tests you need to call first.

Obviously, a test that is also used in another test is useless as test by itself since its test is also performed by "another test". It's a "fake test", looks good in test count, but it is not testing anything that isn't covered by other tests already.
You can simply drop those fake tests as test (you still need the code for the "another test" that uses it though). That should also be a simple thing to change.

The complicated part comes in finding better tests, which do proper testing. Making a new issue for it is likely useless, as nobody is going to fix that I think.

Originally posted by @alberth in #12 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant