Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model files shouldn't be hardcoded in anyway #46

Open
ar13pit opened this issue May 22, 2019 · 1 comment
Open

Model files shouldn't be hardcoded in anyway #46

ar13pit opened this issue May 22, 2019 · 1 comment
Labels
enhancement

Comments

@ar13pit
Copy link
Contributor

ar13pit commented May 22, 2019

In image_recognition launch file, the keras age gender model has a date in its file name. This should be replaced by a generalized symlink to the model.
@ar13pit ar13pit mentioned this issue May 22, 2019
Merged
@MatthijsBurgh
Copy link
Member

No need for it to be a symlink. Can also be environment variable. It just shouldn't be hardcoded

@MatthijsBurgh MatthijsBurgh changed the title Replace date based model file names with symlinks Model files shouldn't be hardcoded in anyway May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ar13pit @MatthijsBurgh