diff --git a/.github/workflows/verify_package_workflow.yaml b/.github/workflows/verify_package_workflow.yaml index 160f4508..b87337de 100644 --- a/.github/workflows/verify_package_workflow.yaml +++ b/.github/workflows/verify_package_workflow.yaml @@ -70,14 +70,20 @@ jobs: uses: fujidaiti/dart-package-inspector@v2.0.4 with: report: ${{ steps.analysis.outputs.json_output }} - min-pub-points: 130 + min-pub-points: 150 - - name: ๐Ÿ›‚ Set up file system write permissions - run: sudo chown -R runner:runner $(pwd) && sudo chmod -R 777 $(pwd) + - name: ๐Ÿ“ฅ Install DCM + if: ${{ github.event_name == 'pull_request' }} + uses: CQLabs/setup-dcm@v1.1.1 + with: + github_token: ${{ secrets.GITHUB_TOKEN }} - name: ๐Ÿ”Ž Dart Code Metrics if: ${{ github.event_name == 'pull_request' }} - run: dart run dart_code_linter:metrics --fatal-style --fatal-performance --fatal-warnings -r github lib + run: dcm analyze . --congratulate --fatal-style --fatal-warnings --reporter=github + + - name: ๐Ÿ›‚ Set up file system write permissions + run: sudo chown -R runner:runner $(pwd) && sudo chmod -R 777 $(pwd) - name: ๐Ÿงช Run Dart tests if: ${{ !inputs.is_flutter }} diff --git a/packages/sealed_currencies/example/lib/main.dart b/packages/sealed_currencies/example/lib/main.dart index 7edbfba1..5e173ec3 100644 --- a/packages/sealed_currencies/example/lib/main.dart +++ b/packages/sealed_currencies/example/lib/main.dart @@ -21,9 +21,9 @@ void main() { subunitToUnit: 100, unitFirst: true), translations: eurCurrencyTranslations". */ - print(isVikingKrone(const FiatNok())); // Prints "true". - print(isVikingKrone(serbianDinar)); // Prints "null". - print(isVikingKrone(const FiatCzk())); // Prints "false". + print(isVikingKrone(const FiatNok())); // Prints true. + print(isVikingKrone(serbianDinar)); // Prints null. + print(isVikingKrone(const FiatCzk())); // Prints false. FiatCurrency.list .where((currency) => currency.symbol?.contains("kr") ?? false) diff --git a/packages/world_countries/example/lib/widgets/floating_button.dart b/packages/world_countries/example/lib/widgets/floating_button.dart index 349d92e9..55f9d687 100644 --- a/packages/world_countries/example/lib/widgets/floating_button.dart +++ b/packages/world_countries/example/lib/widgets/floating_button.dart @@ -14,7 +14,7 @@ class FloatingButton extends StatelessWidget { onLongPress: () => onPressed(isLong: true), // ignore: prefer-action-button-tooltip, we need long-press here. child: FloatingActionButton( - heroTag: "fab", + heroTag: "FAB", onPressed: () => onPressed(isLong: false), child: AnimatedBuilder( animation: controller,