Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR's description should contain fixes tag. #445

Open
Anshgrover23 opened this issue Dec 30, 2024 · 3 comments
Open

PR's description should contain fixes tag. #445

Anshgrover23 opened this issue Dec 30, 2024 · 3 comments

Comments

@Anshgrover23
Copy link
Contributor

Description

  • All the PRs should include Fixes #issueNumber
  • This thing is mandatory because some issues are solved but they are not closed yet.
@Anshgrover23
Copy link
Contributor Author

CC: @seveibar yours take!

@seveibar
Copy link
Contributor

yea prs should generally contain that tag 👍, but not sure how to enforce that. Also probably not mandatory because people fixing small things might not have an associated issue 🤔

@Anshgrover23
Copy link
Contributor Author

Anshgrover23 commented Dec 31, 2024

@seveibar ok but we can like create general pull request template that automatically pre-fills the PR description when someone creates a new pull request, we can create Issue Template.md file as well as pr template file for that.

example:
`## Description

Please provide a short summary of the changes in this pull request.


Checklist

  • My code follows the repository's style guidelines.
  • I have performed a self-review of my code.
  • I have added comments in my code where necessary.
  • I have updated the documentation, if needed.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Linked Issues

Resolves # (issue number)


Screenshots (if applicable)

Add screenshots to showcase the feature or bug fix.
`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants