Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding Style #4

Open
EternalDeiwos opened this issue Aug 22, 2017 · 1 comment
Open

Coding Style #4

EternalDeiwos opened this issue Aug 22, 2017 · 1 comment

Comments

@EternalDeiwos
Copy link
Member

As discussed in various hangouts, issues and PRs (anvilresearch/jwa#8 for example): we have a particular style of coding. This issue is for formally establishing, discussing and querying these coding guidelines with the intention of it being published alongside, or within our CONTRIBUTOR.md document.

@christiansmith
Copy link
Member

christiansmith commented Aug 26, 2017

I propose we add a checklist to this issue for things to discuss, agree upon, and document.

  • package structure
  • comments
  • whitespace
  • naming conventions
  • classes, inheritance, mixins, and modules
  • functions and methods
  • use of functional style vs object orientation
  • variable and constant declarations
  • destructuring assignment
  • promise chaining
  • dependency injection (constructor)
  • testing
    • test descriptions and organization
    • data driven testing
    • assertion style
    • mocks and spies
    • http mocking

What other code style and patterns would we want to discuss and document?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants