Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132930 / 24.10.2 / add get_name implementation for exports. (#16833) #262

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

anodos325
Copy link

This fixes a serious performance problem with NFS handling of large directories, as the new get_name code is much more efficient than the default zfs_readdir. This is actually part of
20232ec in 2.3. But I've taken only the minimum code to implement get_name, and not the rest of the long name changes.

Reviewed-by: Alexander Motin [email protected]
Reviewed by: Brian Behlendorf [email protected]
Reviewed by: Brian Behlendorf [email protected]
Reviewed-by: Tony Hutter [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

This fixes a serious performance problem with NFS handling of large
directories, as the new get_name code is much more efficient than the
default zfs_readdir. This is actually part of
20232ec in 2.3. But I've taken only
the minimum code to implement get_name, and not the rest of the long
name changes.

Signed-off-by: Charles Hedrick <[email protected]>
Co-authored-by: Charles L. Hedrick <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed by: Brian Behlendorf <[email protected]>
Reviewed by: Brian Behlendorf <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
@bugclerk bugclerk changed the title add get_name implementation for exports. (#16833) NAS-132930 / 24.10.2 / add get_name implementation for exports. (#16833) Dec 6, 2024
@bugclerk
Copy link

bugclerk commented Dec 6, 2024

@anodos325 anodos325 requested a review from amotin December 6, 2024 13:04
@yocalebo yocalebo requested a review from ixhamza December 6, 2024 13:04
@anodos325
Copy link
Author

This is targeted fix for issue rather than backport of entire ZFS long name commit.

@anodos325 anodos325 merged commit c71d2fb into stable/electriceel Dec 6, 2024
20 of 22 checks passed
@anodos325 anodos325 deleted the NAS-132930 branch December 6, 2024 14:14
@bugclerk
Copy link

bugclerk commented Dec 6, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants