Remove inode_owner_or_capable override for secpolicy (#178)

This commit fixes a bug whereby owner@ ACL that limits WRITE_DATA access for the owner of a file was not being properly enforced. The owner of a file should be prevented from write access in this case, but being owner of file should still allow the file owner to chmod, chown, and setacl. Signed-off-by: Andrew Walker <[email protected]>
truenas · Jan 8, 2024 · 7929caf · 7929caf
1 parent a64cfeb
commit 7929caf
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/module/os/linux/zfs/policy.c b/module/os/linux/zfs/policy.c
@@ -120,10 +120,7 @@ secpolicy_vnode_access2(const cred_t *cr, struct inode *ip, uid_t owner,
 		return (0);
 	}
 
-	if ((uid == owner) || (uid == 0))
-		return (0);
-
-	if (zpl_inode_owner_or_capable(kcred->user_ns, ip))
+	if (uid == 0)
 		return (0);
 
 #if defined(CONFIG_USER_NS)