NAS-133007 / 24.10.1 / Pass app for update method for ConfigService (by anodos325) #15175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we have pair of update/do_update methods for a ConfigService we need to pass the authenticated credentials between them so that the latter method is called with appropriate privileges. If this doesn't happen, then in addition to the obvious problem of getting a privileged credential passed to the do_update method we also lose credential information for a job log if the method has a job decorator. (cherry picked from commit b14e7d9)
anodos325
force-pushed
the
NAS-133007-24.10.1
branch
from
3150402 to
da0c051
Compare
anodos325
approved these changes
Dec 10, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have pair of update/do_update methods for a ConfigService we need to pass the authenticated credentials between them so that the latter method is called with appropriate privileges. If this doesn't happen, then in addition to the obvious problem of getting a privileged credential passed to the do_update method we also lose credential information for a job log if the method has a job decorator.
Original PR: #15173
Jira URL: https://ixsystems.atlassian.net/browse/NAS-133007