NAS-132989 / 25.04 / Fix failing SMB tests #15167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
yocalebo
approved these changes
Dec 10, 2024
This fixes two failing auxiliary parameters tests that were caused because the output type of a private API for SMB share parameters was changed from string to a list in some cases. It also fixes a test regression for case where SMB share precheck is called without arguments.
anodos325
force-pushed
the
fix-smb-failing-tests
branch
from
0efe5c8 to
5c38758
Compare
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two failing auxiliary parameters tests that were caused because the output type of a private API for SMB share parameters was changed from string to a list in some cases.
It also fixes a test regression for case where SMB share precheck is called without arguments.