Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brighten dark mode text a little to improve readability (master branch; backports needed) #3339

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

Mrt134
Copy link
Collaborator

@Mrt134 Mrt134 commented Dec 5, 2024

Had a request come in to brighten the off-white text a little more in dark mode so there would be a starker contrast. Made the adjustment for the variable --body-font-color only in dark mode and automatic dark mode selectors. Please review and send feedback. If this change is good to merge, then we'll backport to the other active branches too.

Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.

Had a request come in to brighten the off-white text a little more in dark mode so there would be a starker contrast. Made the adjustment for
@Mrt134 Mrt134 requested a review from a team as a code owner December 5, 2024 17:18
@Mrt134 Mrt134 changed the title Brighten dark mode text a little to improve readability (backports needed) Brighten dark mode text a little to improve readability (master branch; backports needed) Dec 6, 2024
@micjohnson777 micjohnson777 added the Technical Writer Review (MJ) A technical writer is reviewing the PR. label Dec 9, 2024
Copy link
Contributor

@micjohnson777 micjohnson777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks good.

@micjohnson777 micjohnson777 merged commit 2f39aa9 into master Dec 9, 2024
3 checks passed
@micjohnson777 micjohnson777 deleted the dark_mode_color branch December 9, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Writer Review (MJ) A technical writer is reviewing the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants