Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty URLs are dumped to browser console #14

Open
kirill-konshin opened this issue Apr 12, 2017 · 2 comments
Open

Empty URLs are dumped to browser console #14

kirill-konshin opened this issue Apr 12, 2017 · 2 comments

Comments

@kirill-konshin
Copy link
Contributor

This line https://github.com/troybetz/react-soundcloud-widget/blob/master/src/SoundCloud.js#L119 is causing lots of 404 errors to be dumped to console:

src="https://w.soundcloud.com/player/?url="

You need to open IFRAME with some other URL that is more safe.

@strachsel
Copy link

Hey Kirill, were you able to find a workaround here? It works for one track, but when I add a couple of tracks, the rest of them don't render and throw empty urls and 404s.

@kirill-konshin
Copy link
Contributor Author

Nope. I ended up dropping the widget, I now just add an IFRAME because I don't need to track play/pause statuses or integrate in any other way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants